Change access to method request....

This forum is for programmers who have questions about the source code.
Post Reply
indev
Posts: 6
Joined: Mon May 06, 2013 4:22 pm

Change access to method request....

Post by indev » Mon May 06, 2013 4:29 pm

Is it possible to change the method: TryToSaveData() in FormSheetFillEdit to public from private? I am trying to add some functionality to the Sheets via a plugin and I need to be able to run this method from the instance that is passed to the plugin.

thanks.

indev
Posts: 6
Joined: Mon May 06, 2013 4:22 pm

Re: Change access to method request....

Post by indev » Tue May 14, 2013 2:25 pm

Hmmm...is this not the right forum for questions like this?

User avatar
drtech
Posts: 1647
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: Change access to method request....

Post by drtech » Tue May 14, 2013 2:41 pm

Yes, this is the right place...just need an OD developer to look at it...they might do that for you...
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

User avatar
jsalmon
Posts: 1551
Joined: Tue Nov 30, 2010 12:33 pm
Contact:

Re: Change access to method request....

Post by jsalmon » Tue May 14, 2013 4:02 pm

I sent an email to my boss on the tenth asking if we change access modifiers for this purpose. Haven't gotten a reply back yet, I'll post once I get an answer.
The best thing about a boolean is even if you are wrong, you are only off by a bit.

Jason Salmon
Open Dental Software
http://www.opendental.com

User avatar
jordansparks
Site Admin
Posts: 5739
Joined: Sun Jun 17, 2007 3:59 pm
Location: Salem, Oregon
Contact:

Re: Change access to method request....

Post by jordansparks » Wed May 15, 2013 4:04 pm

I'm having trouble understanding why. You're passing in an instance of that form? So the user isn't actually using the UI in that form? You're just using it as a container to simulate user input?
Jordan Sparks, DMD
http://www.opendental.com

indev
Posts: 6
Joined: Mon May 06, 2013 4:22 pm

Re: Change access to method request....

Post by indev » Thu May 16, 2013 8:56 am

No the plugin uses the current UI, but it adds an additional button (much like the Email/PDF one) that needs to execute that function. Since the button event handler (and constructor, etc.) is in the plugin and not the main prog it needs to call the function from the instance that is passed. Unfortunately I can't because it is private. If it was a public function I could call the TryToSaveData() then continue... I can't think of any other way to make this work, but I am willing to try anything else if I am approaching this incorrectly. Thank you for your input.

indev
Posts: 6
Joined: Mon May 06, 2013 4:22 pm

Re: Change access to method request....

Post by indev » Mon May 20, 2013 6:17 pm

I hate to bug about this, but just curious if you have had a chance to consider this request. I have tried working around it, but I can't do much with the sheet until it is saved. I even looked at re-implementing the save method for the plugin, but that would be a lot of wasted work (and could lead to some serious problems if the internal save method ever changed.)

indev
Posts: 6
Joined: Mon May 06, 2013 4:22 pm

Re: Change access to method request....

Post by indev » Mon Jun 03, 2013 10:56 am

Just curious what the status of this is...

thanks.

User avatar
jsalmon
Posts: 1551
Joined: Tue Nov 30, 2010 12:33 pm
Contact:

Re: Change access to method request....

Post by jsalmon » Wed Jun 12, 2013 10:59 am

I would recommend emailing Dr. Sparks directly about this. He is the only one that can give the approval for such a change: jsparks@free-dental.com
The best thing about a boolean is even if you are wrong, you are only off by a bit.

Jason Salmon
Open Dental Software
http://www.opendental.com

Post Reply