Referral button in patient edit window.

This forum is for programmers who have questions about the source code.
Post Reply
User avatar
jordansparks
Site Admin
Posts: 5744
Joined: Sun Jun 17, 2007 3:59 pm
Location: Salem, Oregon
Contact:

Referral button in patient edit window.

Post by jordansparks » Sat Dec 08, 2007 10:48 am

I had to remove this new button because of the following problems:
1. Leading spaces instead of tabs. Large sections of the file were affected due to designer generated code.
2. I don't recall any discussion before adding this new feature.
3. The code for the event was located at the end of the file instead of further up.
4. It's clutter.
5. Most importantly, it does not account for a new patient situation. The whole reason why referrals were moved out of this window in the first place is because if user clicks cancel in this window, it deletes the patient object from the db. I believe this would leave an orphaned foreign key in the referral table.
Jordan Sparks, DMD
http://www.opendental.com

User avatar
drtech
Posts: 1649
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Post by drtech » Sun Dec 09, 2007 6:46 am

Sorry for the problems, that is why you are the man. :)
1)I forgot to change that setting back when I reinstalled...i will fix that on future postings
"Large sections of the file were affected due to designer generated code."
- is this because the spacing was messed up or something else I need to avoid?
2)It was brought about in a thread in the advanced or main forum from a user about where to add referrals again...it looked easy to add this options to me, so I did.
3) I guess I need to move the events when VS creates then to a logical place?
4) see below
5) The reason I see it as necessary: You would like to enter referral on the phone with new pt if you know it. When you sched an appt for a new pt, we usually double click on the book, the select pt window comes us, you don't find the pt in the database, you add the pt, the pt edit window appears, you enter the info and then sched the appt. The family module never appears. So if you wanted to enter the referral, you have to go to the family module after.

I certainly understand the logic in not created orphaned keys. Any suggestions on making this work without this problem?

again sorry for the problems and I love OD!
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

User avatar
jordansparks
Site Admin
Posts: 5744
Joined: Sun Jun 17, 2007 3:59 pm
Location: Salem, Oregon
Contact:

Post by jordansparks » Mon Dec 10, 2007 3:34 pm

1. I just meant that the leading spaces were messed up in large portions of the code, so that change would fix it.
3. Delete, OK, and Cancel events always come at the end of the file, that's all.
5. Oh, I forgot that the family module never appears. But usually, the referral is determined from their paperwork, which is entered after the initial appointment is set. So you don't need to initially enter the referral.

There is a long term plan to address this issue. The sheets feature will let a user set up a "form/sheet" which contains exactly the input boxes that they want. In other words, a customizable patient edit window. So the "clutter" issue becomes a non-issue.

It would be a hassle to add that button because you'd have to make sure to delete the foreign key if the user hits cancel.
Jordan Sparks, DMD
http://www.opendental.com

User avatar
drtech
Posts: 1649
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Post by drtech » Tue Dec 11, 2007 6:34 am

ok, we will forget about it for now....
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

Post Reply