Page 1 of 1

Request: Move hook for Open Dental 20.1

Posted: Mon Mar 23, 2020 8:14 pm
by Justin Shafer
Hi, I was wondering if I could remove what is red and add what is green, for the IOC Snapshot plugin. Currently if the plugin is enabled it always overrides the mount import. I would like to move a hook so that way if you have a mount up, you can import inside of it, even with the plugin enabled.

Mounts are really neat! I was going to request a hook for it, but I realized I cannot get a handle on the current category, and the available tiles inside of the mount. Would be cool if we could use twain to import directly into mounts with multiple pages being separate tiles! Then I wouldn't really need my plugin anymore and would work even better with thinfinity.

ContrImagesJ.cs @ Line 2344
private void ToolBarImport_Click(){
if(Plugins.HookMethod(this,"ContrImages.ToolBarImport_Click_Start",_patCur)) {
FillTree(true);
return;
}

if(IsMountShowing()){
ToolBarImportMount();
}
else{//including nothing selected
ToolBarImportSingle();
}
}

ContrImagesJ.cs @ Line 2444
private void ToolBarImportSingle(){
if(Plugins.HookMethod(this,"ContrImages.ToolBarImport_Click_Start",_patCur)) {
FillTree(true);
return;
}

Re: Request: Move hook for Open Dental 20.1

Posted: Tue Mar 24, 2020 8:29 am
by jordansparks
We don't usually move hooks, but this one makes sense because it preserves original behavior.

Re: Request: Move hook for Open Dental 20.1

Posted: Wed Mar 25, 2020 8:03 am
by cmcgehee
I'll take care of getting this changed.

Re: Request: Move hook for Open Dental 20.1

Posted: Wed Mar 25, 2020 3:38 pm
by cmcgehee
Justin, the change for this hook has been backported to 20.1.5.

Re: Request: Move hook for Open Dental 20.1

Posted: Sun Mar 29, 2020 11:21 am
by Justin Shafer
Thank you very much!

Re: Request: Move hook for Open Dental 20.1

Posted: Tue Oct 13, 2020 6:52 am
by Justin Shafer
So uhhh.. anyway to revert this???

You guys had it right the first time.. :D

Actually I need to think this through more.. nevermind...

Re: Request: Move hook for Open Dental 20.1

Posted: Tue Oct 13, 2020 7:43 am
by Justin Shafer
YES.. I am sure of it.. this would be awesome if I could get it reverted.....

I added the ability to save images into a mount... but the toolbar hook doesn't fire if the person is looking at a mount....

i am finding a mount based on a name and if it exists I create a new mount on that name and import the images into that mount....

Re: Request: Move hook for Open Dental 20.1

Posted: Tue Oct 13, 2020 11:53 am
by joes
Hi Justin,
To maintain compatibility for others who may use this hook, we left the one that is in ToolBarImportSingle() as is and added a second hook to ToolBarImport_Click(). Note that "Alternate" is appended to the name. This will be available in 20.3.35 and 20.4.6 upon their release.

private void ToolBarImport_Click() {
if(Plugins.HookMethod(this,"ContrImages.ToolBarImport_Click_Start_Alternate",_patCur)) {
FillTree(true);
return;
}
if(IsMountShowing()){
ToolBarImportMount();
}
else{//including nothing selected
ToolBarImportSingle();
}
}

Re: Request: Move hook for Open Dental 20.1

Posted: Wed Oct 14, 2020 1:11 am
by Justin Shafer
Thank You!!!!

Re: Request: Move hook for Open Dental 20.1

Posted: Wed Oct 14, 2020 1:56 am
by Justin Shafer
FYI compiling the HEAD version... Seems to require a registration key.. so removed that...

Also requires VirtualWeb.dll but the one you guys give out to the public doesn't have a cookie call in it... so removed that requirement for Imaging Devices Form....

Gotta update the stub. =)

Like the new icons and look!

Imaging Devices can use Twain now.. but... multi-page transfers do not seem to work... Haven't looked at the eztwain code yet... But if that works then the plugin isnt really needed anymore... (a GOAL). =) Then again I have some customization into the plugin.. image descriptions, ability to pick tooth numbers per image, etc...