Convert.ToBoolean in OD 19.4

[wjstarck]

This code has been working for many years, but is suddenly broken in OD 19.4

Code: Select all

string command = "SELECT AddEnhancedMenuItems FROM anesthpreference";
return Convert.ToBoolean(DataCore.GetScalar(command));

So to get it working, I have to rewrite it as

Code: Select all

string command = "SELECT AddEnhancedMenuItems FROM anesthpreference";
string result = DataCore.GetScalar(command);
bool prefResult = Convert.ToBoolean(Convert.ToInt32(result));
return prefResult;

Why?

[cmcgehee]

Did you used to store AddEnhancedMenuItems as "true" and now you're storing it at "1"?

[wjstarck]

Always stored as 1 or 0

[cmcgehee]

When I run Convert.ToBoolean("1") in C# 7.3 using .NET Framework 4.5.2 in Visual Studio 2019, it gives a FormatException. I cannot vouch for its behavior in older versions of C# or .NET.

[wjstarck]

Chris-

I store those as tinyints in my tables instead of bools. Could that be the problem?

[cmcgehee]

I don't think so. We store bools as tinyints as well.