Ins Benefits in account

This forum is for programmers who have questions about the source code.
Post Reply
User avatar
drtech
Posts: 1649
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Ins Benefits in account

Post by drtech » Mon Jun 02, 2008 9:44 am

Jordan,
Question...did you want the ins benefits to not show on the account for speed or another reason or is that a bug? (that maybe I introduced yesterday when I compiled 5.7.) Been using it at the office today and hadn't had a chance to look at the code, but it doesn't show up until you mouse over it.
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

User avatar
jordansparks
Site Admin
Posts: 5744
Joined: Sun Jun 17, 2007 3:59 pm
Location: Salem, Oregon
Contact:

Re: Ins Benefits in account

Post by jordansparks » Mon Jun 02, 2008 7:17 pm

I'm not looking at the code right now, but the intention was to not make those expensive calls to the database until that panel was made visible by hover over. I don't remember actually testing it, so it's likely that I introduced a bug. I will take another look at it. But we cannot allow those expensive calls separate from the dataset.
Jordan Sparks, DMD
http://www.opendental.com

User avatar
drtech
Posts: 1649
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: Ins Benefits in account

Post by drtech » Tue Jun 03, 2008 6:27 am

yes, I figured it was for speed and efficiency...can I make it part of the "data sheet"? do you mean include it as part of the business layer so everything is returned with one call? I will look at it too and try to see what exactly you mean.
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

User avatar
jordansparks
Site Admin
Posts: 5744
Joined: Sun Jun 17, 2007 3:59 pm
Location: Salem, Oregon
Contact:

Re: Ins Benefits in account

Post by jordansparks » Tue Jun 03, 2008 2:30 pm

I'm OK with not making it part of the business layer because I consider it "fluff". In fact, I think it's better to call it on an as-needed basis. This is assuming that it will not be needed until the popup panel shows. Anything that must show on the main screen right from the start, we should try hard to include in the business layer. Please don't touch it until after Wed, when I get back from vacation. I also don't want to clutter the business layer unnecessarily.
Jordan Sparks, DMD
http://www.opendental.com

User avatar
drtech
Posts: 1649
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: Ins Benefits in account

Post by drtech » Tue Jun 03, 2008 5:39 pm

sure thing
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

Post Reply