Default note still appending to completed notes (bug)

This forum is for programmers who have questions about the source code.
Post Reply
User avatar
wjstarck
Posts: 936
Joined: Tue Jul 31, 2007 7:18 am
Location: Keller, TX
Contact:

Default note still appending to completed notes (bug)

Post by wjstarck » Tue Mar 15, 2011 6:25 am

I still think there's a bug with the default note getting appended even if there are notes already saved for a procedure.

How to reproduce:

1)Enter a default note for a procedure code
2)Complete the procedure to show the default note
3)Edit the default note and click OK. Set the default note back to treatment planned (Staff often need to do this to have a procedure show on the treatment plan for financial discussion).
4)Set the procedure complete. The blank default note will be appended to the edited default note.

I find if I change line 3302 on FormProcEdit to:

Code: Select all

if (textNotes.Text == String.Empty) {
textNotes.Text += ProcCodeNotes.GetNote(provNum, ProcCur.CodeNum);
}
and line 1320 on Procedures to:

Code: Select all

if (ProcList[i].Note == String.Empty) {
The problem goes away completely.

Thanks.
Cheers,

Bill Starck, DDS
Big Idea Software, LLC
Developer, EASy(Electronic Anesthesia System) for Open Dental
817-807-1709
TX, USA

User avatar
drtech
Posts: 1649
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: Default note still appending to completed notes (bug)

Post by drtech » Tue Mar 15, 2011 4:23 pm

good catch...
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

User avatar
jordansparks
Site Admin
Posts: 5744
Joined: Sun Jun 17, 2007 3:59 pm
Location: Salem, Oregon
Contact:

Re: Default note still appending to completed notes (bug)

Post by jordansparks » Wed Mar 16, 2011 6:55 pm

It's behaving exactly like it was designed. They can change the status back to complete instead of "setting complete" if they don't want the note again.
Jordan Sparks, DMD
http://www.opendental.com

User avatar
drtech
Posts: 1649
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: Default note still appending to completed notes (bug)

Post by drtech » Thu Mar 17, 2011 9:31 am

But don't you agree it is better to have not append the note again?

hum...but then you don't know if the default note as been written or of another type of note was added...so I agree...that it should stay as it currently is.
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

Post Reply