First thing I want to note, as a sideline, is that OpenDental\Main Modules\FormOpenDental.cs doesn't conform to the Coding Standard as there are a number of lines which are indented using spaces rather than tabs as required.
I came across that while making a change as follows:
Name of help file
The helpfile should be called "OpenDental Help.chm" rather than just "Help.chm". (Think about every app on your drive calling their help file the same thing...)
Rather than hard-code that I propose simply adding the following declaration:
Code: Select all
private System.Windows.Forms.MenuItem menuItemHelpWindows;
+ private string helpFileName = "OpenDental Help.chm";
Code: Select all
if(CultureInfo.CurrentCulture.TwoLetterISOLanguageName=="en"){
menuItemTranslation.Visible=false;
}
- if(!File.Exists("Help.chm")){
+ if(!File.Exists(helpFileName)){
menuItemHelpWindows.Visible=false;
Code: Select all
private void menuItemHelpWindows_Click(object sender, System.EventArgs e) {
try{
- Process.Start("Help.chm");
+ Process.Start(helpFileName);
I think the Help menu should be laid out a little differently to better conform to UI guidelines as follows
Contents
-
Online Help - Contents
Online Help - Index
-
Online Support
-
Update
This can easily be achieved with declarations of the form:
Code: Select all
private System.Windows.Forms.MenuItem menuItemHelpSeparator1;
Code: Select all
if(!File.Exists(helpFileName)){
menuItemHelpWindows.Visible=false;
+ menuItemHelpSeparator1.Visible = false;
}
If you'd like, I can provide a patch file against head. I'd assume you'd prefer a unified rather than context diff?