Minor "bug" in the user password form

[richardwaite]

In FormUserPassword the tab indexes don't make much sense to me. "New Password" is 0, "OK" is 1, "Cancel" is 2, and "New Password Again" is 3. I would expect it to be: "New Password" 0, "New Password Again" 1, "OK" 2, "Cancel" 3. Also, pressing the Enter key does not seem to trigger "OK". I'm not sure how to change that, but the tab indexes are pretty easy to change. Not really a big deal, just some quirks I've noticed.

[jordansparks]

That is common in many forms. There are so many forms where textboxes accept an Enter, that we really have gotten away from an Enter closing the form. Yes, this is one case where we could have Enter close the form, but it would be more of an exception to the norm. As for tab order, we try to maintain it. But if it gets out of order, we classify it as an annoyance rather than a bug.

[richardwaite]

What would be the best way to fix these annoyances, then? I would be billing to email or post diffs if that would be acceptable. I'm speaking about only minor things here, like tab order or other UI quirks.

[jordansparks]

Your post looks malformed. I don't understand "billing to email". Our only allowed way for outside developers to make alterations is with a plugin. Tab order could be easily changed with a plugin. The plugin would also prevent later alteration. One disadvantage is that if we ever change a control name, you wouldn't know it and your plugin would crash. This could be avoided by a quick testing script or by writing a program that validates your control names.

[richardwaite]

Sorry, "billing" should be "willing." So you do not accept patches from outside developers at all? A plugin for this kind of change just strikes me as overkill. It would have to be installed on all machines and maintained - does tab order really change that often? The only reason I brought this specific issue up is every new user I've seen setup a user and try to change the password hits tab and is confused because it does not do what they expect. It would be nice to have this and similar issues go away, and I'm willing to devote time to it - but I don't think plugins are the answer.

[jordansparks]

Changed it in that form.

[richardwaite]

Thanks.