beta (v17.2.7) Ins error causes crash

For complex topics that regular users would not be interested in. For power users and database administrators.
Post Reply
User avatar
drtech
Posts: 1647
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

beta (v17.2.7) Ins error causes crash

Post by drtech » Thu Aug 03, 2017 10:01 am

I mentioned this a few weeks ago when it happened to one pt, but I continue to have problems on other pts as well. A few times a week we are getting errors on a pt that I have traced down to the ins plans. It

gives this error:
Unhandled exception from ProgramEntry: Object reference not set to an instance of an object.
System.NullReferenceException
at OpenDental.ContrFamily.FillInsData() in C:\SVN\beta\OpenDental\Main Modules\ContrFamily.cs:line 2498
at OpenDental.ContrFamily.RefreshModuleScreen() in C:\SVN\beta\OpenDental\Main Modules\ContrFamily.cs:line 504
at OpenDental.ContrFamily.ModuleSelected(Int64 patNum) in C:\SVN\beta\OpenDental\Main Modules\ContrFamily.cs:line 333
at OpenDental.FormOpenDental.SetModuleSelected(Boolean menuBarClicked) in C:\SVN\beta\OpenDental\Main Modules\FormOpenDental.cs:line 5699
at OpenDental.FormOpenDental.myOutlookBar_ButtonClicked(Object sender, ButtonClicked_EventArgs e) in C:\SVN\beta\OpenDental\Main Modules\FormOpenDental.cs:line 5657
at OpenDental.OutlookBar.OnButtonClicked(OutlookButton myButton, Boolean myCancel) in C:\SVN\beta\OpenDental\User Controls\OutlookBar.cs:line 321
at OpenDental.OutlookBar.OnMouseUp(MouseEventArgs e) in C:\SVN\beta\OpenDental\User Controls\OutlookBar.cs:line 313
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

If I run DB maint it fixes it the issue and puts in an "Unknown Carrier" for the insurance plan. I am not sure what is happening, but obviously an inerrant ins plan is getting partially entered. Any else able to replicate?
Last edited by drtech on Thu Aug 03, 2017 10:23 am, edited 1 time in total.
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

User avatar
drtech
Posts: 1647
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: beta (17.2.7) Ins error causes crash

Post by drtech » Thu Aug 03, 2017 10:21 am

Was able to replicate. Happens if you start creating an ins plan and then cancel out before saving. It crashes as soon as you hit cancel and the inerrant plan get added.
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

User avatar
jsalmon
Posts: 1551
Joined: Tue Nov 30, 2010 12:33 pm
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by jsalmon » Thu Aug 03, 2017 11:11 am

I'll look into this myself. I've been trying to track down the root of this issue for a while and this sounds too good to be true.
The best thing about a boolean is even if you are wrong, you are only off by a bit.

Jason Salmon
Open Dental Software
http://www.opendental.com

User avatar
jsalmon
Posts: 1551
Joined: Tue Nov 30, 2010 12:33 pm
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by jsalmon » Thu Aug 03, 2017 11:31 am

I'm unable to duplicate the problem. It might have to do with specific steps that you are taking that I am not or some sort of setting that you have that I do not. Can you either provide me with detailed steps that you are taking to duplicate the problem or PM me so that I can give you some SFTP credentials to upload your database to me for debugging purposes?

E.g. Steps I'm taking:
  1. Create new patient via Select Patient window.
  2. Click the Family module button.
  3. Click the Add Insurance button.
  4. "Is this patient the subscriber?" > Click Yes.
  5. Do absolutely nothing > Click Cancel.
  6. Leave Family module by clicking the Chart module button and then go back to Family module by clicking the Family module button. No errors.
  7. Run DBM and all report "Done. No maintenance needed."
The best thing about a boolean is even if you are wrong, you are only off by a bit.

Jason Salmon
Open Dental Software
http://www.opendental.com

User avatar
drtech
Posts: 1647
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by drtech » Fri Aug 04, 2017 11:14 am

Steps I took and create the problem:
1) Used Existing pt
2) Clicked Family module
3)Clicked add insurance button
4)Is this pt the subscriber? > Clicked yes
5) In this case, pt already had an ins plan, so clicked add new plan
6)Did nothing in the ins plan edit windows
7)Clicked cancel
8) Immediately program crashes with error message
9) can't load this pt again in the family or account or chart without program crashing again
10) Ran DBM and it fixed it
11) plan entered in family file that says "unknown subscriber"
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

User avatar
drtech
Posts: 1647
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by drtech » Fri Aug 04, 2017 11:15 am

Did it to me again when I made a new pt, just the same....linux capitalization error?...i don't even see InsEditLog in my database at all, capitalization or not?

Unhandled exception from ProgramEntry: Table 'opendental.InsEditLog' doesn't exist
MySql.Data.MySqlClient.MySqlException
at OpenDentBusiness.DataConnection.NonQ(String commands, Boolean getInsertID, OdSqlParameter[] parameters) in C:\SVN\beta\OpenDentBusiness\Db\DataConnection.cs:line 759
at OpenDentBusiness.DataCore.NonQ(String command, Boolean getInsertID, OdSqlParameter[] parameters) in C:\SVN\beta\OpenDentBusiness\Db\DataCore.cs:line 34
at OpenDentBusiness.Db.NonQ(String command, Boolean getInsertID, OdSqlParameter[] parameters) in C:\SVN\beta\OpenDentBusiness\Db\Db.cs:line 89
at OpenDentBusiness.Db.NonQ(String command, OdSqlParameter[] parameters) in C:\SVN\beta\OpenDentBusiness\Db\Db.cs:line 99
at OpenDentBusiness.InsEditLogs.DeletePreInsertedLogsForPlanNum(Int64 planNum) in C:\SVN\beta\OpenDentBusiness\Data Interface\InsEditLogs.cs:line 106
at OpenDental.FormInsPlan.FormInsPlan_Closing(Object sender, CancelEventArgs e) in C:\SVN\beta\OpenDental\Forms\FormInsPlan.cs:line 5677
at System.Windows.Forms.Form.OnClosing(CancelEventArgs e)
at System.Windows.Forms.Form.CheckCloseDialog(Boolean closingOnly)


I can send database if needed
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

JoeMontano
Posts: 64
Joined: Thu Aug 20, 2015 11:08 am

Re: beta (v17.2.7) Ins error causes crash

Post by JoeMontano » Fri Aug 04, 2017 12:45 pm

To clarify are you saying on your linux server there is no inseditlog table in opendental? The capitalization of "InsEditLog" sounds like the issue but if you do not have the lower case table either that seems strange to me.
Joe Montaño
Software Engineer
Open Dental Software
Joe@OpenDental.com

User avatar
jsalmon
Posts: 1551
Joined: Tue Nov 30, 2010 12:33 pm
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by jsalmon » Fri Aug 04, 2017 1:07 pm

Joe submitted a bug ticket for the capitalization issue but he's also correct in that you should have an inseditlog table which should have been added in the 17.2.1 script. Do you have a "stmtlink" table? That table got added after the "inseditlog" table. If you don't have either then you must have compiled your own v17.2 and started using it before we officially released v17.2 to the public? That would be my only guess.
The best thing about a boolean is even if you are wrong, you are only off by a bit.

Jason Salmon
Open Dental Software
http://www.opendental.com

User avatar
jsalmon
Posts: 1551
Joined: Tue Nov 30, 2010 12:33 pm
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by jsalmon » Fri Aug 04, 2017 5:14 pm

I was just notified that the but "Linux, accessing the edit patient information window would throw a UE sometimes." has been fixed and will be released with v17.2.10
http://opendentalsoft.com:1942/ODBugTra ... .aspx#17.1
The best thing about a boolean is even if you are wrong, you are only off by a bit.

Jason Salmon
Open Dental Software
http://www.opendental.com

User avatar
drtech
Posts: 1647
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by drtech » Mon Aug 07, 2017 11:19 am

Yes, I complied my own. I thought the convention was that no new database changes occur on minor version (bug fix) changes so that would be safe? I will always update only to an exact release point if that is what I must do, but usually I just update to the latest svn, compile it and run it. I will look at the database upgrade section and see if it would be safe for me to move that section of the script to a latest release point or what would be involved. Any other suggestions before I look at that option?
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

User avatar
jsalmon
Posts: 1551
Joined: Tue Nov 30, 2010 12:33 pm
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by jsalmon » Mon Aug 07, 2017 12:19 pm

drtech wrote:I thought the convention was that no new database changes occur on minor version (bug fix) changes so that would be safe?
We try not to but it does happen every once in a while. Regardless, you were not affected by a "minor version (bug fix)" convert script. You were affected by a root (17.2.1) convert script. You probably saw that we branched the code but weren't aware that we were still actively programming to finish features before publicly releasing v17.2. We've gotten much larger as a company and so we have to branch much earlier in the release cycle so that the majority of our engineering department can continue to work on new features for the next version while the rest finish up partially completed features.
The best thing about a boolean is even if you are wrong, you are only off by a bit.

Jason Salmon
Open Dental Software
http://www.opendental.com

User avatar
jsalmon
Posts: 1551
Joined: Tue Nov 30, 2010 12:33 pm
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by jsalmon » Mon Aug 07, 2017 12:22 pm

I'll try and conjure up a way so that users like you that compile the code can't fall victim to this paradigm. It's a very tricky problem to commandeer...
The best thing about a boolean is even if you are wrong, you are only off by a bit.

Jason Salmon
Open Dental Software
http://www.opendental.com

User avatar
jsalmon
Posts: 1551
Joined: Tue Nov 30, 2010 12:33 pm
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by jsalmon » Mon Aug 07, 2017 12:29 pm

Because you aren't the only one to fall victim to this:
viewtopic.php?f=2&t=6443
The best thing about a boolean is even if you are wrong, you are only off by a bit.

Jason Salmon
Open Dental Software
http://www.opendental.com

User avatar
drtech
Posts: 1647
Joined: Wed Jun 20, 2007 8:44 am
Location: Springfield, MO
Contact:

Re: beta (v17.2.7) Ins error causes crash

Post by drtech » Tue Aug 08, 2017 5:49 am

Ok, I am back looking at this and when I just looked at my database and I actually HAVE both the "missing" tables in question (inseditlog & stmtlink). I must have missed it the first time looking for the capitalized version. I am still on the same compiled version of 17.2.7 from earlier, so I don't think I actually had a DB problem, just the capitalization issue, so false alarm on that problem, but I see how it could be a potential issue. I am going to update to the newest SVN and see if our issue goes away on the pt ins edit window.

Thanks
David Fuchs
Dentist - Springfield, MO
Smile Dental http://www.887-smile.com

Post Reply